test: use locally published version in E2E project setup #15052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipesilva
reviewed
Jul 12, 2019
| @@ -18,7 +18,7 @@ packages: | |||
| access: $all | |||
| publish: $all | |||
|
|
|||
| '@ngtools/*': | |||
| '@ngtools/webpack': | |||
There was a problem hiding this comment.
Was this change necessary or was it just cleanup? Just wondering, because @angular-devkit/* still has the star above.
There was a problem hiding this comment.
“@ngtools/json-schema” is used by ng-packgr. Since it no longer exists, it’s not published locally which causes the installation of ng-packgr to fail within the E2E tests.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to perform a second special local build of the packages during the E2E test process.
This also has the benefit of causing CI to fail if the package versions in
latest-versions.tsare not kept synchronized with the CLI package versions.